Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kafka Stream instrumentation for library in version 2.6+ #3438

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Fix kafka Stream instrumentation for library in version 2.6+ #3438

merged 1 commit into from
Jun 30, 2021

Conversation

GuillaumeWaignier
Copy link
Contributor

This PR fixes the instrumentation of kafka stream when the library version is above 2.6 #3436

It takes into account the change in the method signature of org.apache.kafka.streams.processor.internals.StreamTask.

  • 2.5 and below : public boolean process()
  • 2.6 and above : public boolean process(final long wallClockTime)

@mateuszrzeszutek mateuszrzeszutek linked an issue Jun 30, 2021 that may be closed by this pull request
Instrumentation not working with kafka stream version above 2.6 #3436
Closed
mateuszrzeszutek
mateuszrzeszutek approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we didn't run latest dep tests for kafka-streams >=2.4 at all...
I'll create a separate issue to remove the latestDepTest bounds.

Thanks for contributing @GuillaumeWaignier !

@mateuszrzeszutek
Copy link
Member

Closing-reopening to trigger EasyCLA check

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 30, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@mateuszrzeszutek
Copy link
Member

@GuillaumeWaignier could you please sign the CLA?

@laurit laurit merged commit 00b1b07 into open-telemetry:main Jun 30, 2021
@judomu
Copy link

judomu commented Jul 13, 2021 •
edited
Loading

When do you plan to release a new version with the bugfix from above?

@mateuszrzeszutek
Copy link
Member

Hi @judomu,
We're planning to release a new version this week.

@tylerbenson tylerbenson mentioned this pull request Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@laurit laurit laurit approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instrumentation not working with kafka stream version above 2.6
4 participants
@GuillaumeWaignier @mateuszrzeszutek @judomu @laurit